Allow partial SONOFF water valve composite settings#12495
Merged
Koenkk merged 2 commits intoJun 22, 2026
Conversation
MaxRink
changed the title
Contributor
Author
|
Validated against a local Docker Home Assistant + MQTT discovery harness. The screenshot shows the rendered HA UI for the composite child entities, Shelly cover lift-only vs slat-capable cover, and SONOFF valve controls.
|
MaxRink
force-pushed
the
sonoff-water-valve-partial-manual-settings
branch
from
7ba0942 to
a77caa3
Compare
Owner
|
thanks! |
CubeZ2mDeveloper
added a commit
to CubeZ2mDeveloper/zigbee-herdsman-converters
that referenced
this pull request
Jul 8, 2026
…Koenkk#12510)" Revert "fix: SONOFF SWV: allow partial water valve composite settings (Koenkk#12495)"
CubeZ2mDeveloper
added a commit
to CubeZ2mDeveloper/zigbee-herdsman-converters
that referenced
this pull request
Jul 9, 2026
…Koenkk#12510)" Revert "fix: SONOFF SWV: allow partial water valve composite settings (Koenkk#12495)"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npx pnpm@10.12.1 run checknpx pnpm@10.12.1 vitest run test/sonoff.test.ts --config ./test/vitest.config.mtsnpx pnpm@10.12.1 vitest run test/shelly.test.ts test/sonoff.test.ts --config ./test/vitest.config.mts